next »

[qbproger]

I was looking through the DaeLoader and saw the InputStreams getting created in there.  Where are those streams supposed to be getting closed?

example:

Code:

public DaeModel loadModel( URL url, String skin ) throws IOException, IncorrectFormatException, ParsingErrorException
    {
        boolean baseURLWasNull = setBaseURLFromModelURL( url );
       
        DaeModel model = loadModel( url.openStream(), skin );
       
        if ( baseURLWasNull )
        {
            popBaseURL();
        }
       
        return( model );
    }

The function that stream is passed into never closes it, and it doesn't get closed by the parser in jagatoo.  Should they be getting closed in Jagatoo after the parsing is done?

Marvin, you mentioned that the ModelLoader code is getting re-worked, is this being fixed as part of that?  I don't know if this is an issue for other loaders, I only looked at the collada loader.

qb

[Marvin Fröhlich]

I saw this in some other loaders, too. I would say, the xith.part of the loader should make sure, the stream is closed. And the JAGaToo-part should also close the stream. I'm not sure, how the final architecture will look like exactly. So this is the safe way .

Marvin