next »

[rwb1977]

QuadArray has a "getTriangle" method.  However, I think it may be wrong.

If i is 0, the indices of the vertices for the triangle are computed as 0, 1, 2.

If i is 1, the indices of the vertices for the triangle are computed as 1, 2, 3.  It should be something like 0, 2, 3 or 2, 3, 0 shouldn't it?  As a result, picking quad arrays results in an unpickable area.

[horati]

Seems like a bug to me.  Marvin wrote the picking library so he'll know more.

[rwb1977]

This seems to be the fix for QuadArray.java:

Code:

/**
     * {@inheritDoc}
     */
    public boolean setTriangle( int i, Triangle triangle )
    {
        final int idx0;
       
        idx0 = ( ( i / 2 ) * 4 ) + 0;
       
        if (i % 2 == 0)
        return ( setTriangle( idx0 + 0, idx0 + 1, idx0 + 2, triangle ) );
        else
        return ( setTriangle( idx0 + 2, idx0 + 3, idx0 + 0, triangle ) );
    }
   
    /**
     * {@inheritDoc}
     */
    public boolean getTriangle( int i, Triangle triangle )
    {
        final int idx0;
       
        idx0 = ( ( i / 2 ) * 4 ) + 0;

        if (i % 2 == 0)
        return ( getTriangle( idx0 + 0, idx0 + 1, idx0 + 2, triangle ) );
        else
        return ( getTriangle( idx0 + 2, idx0 + 3, idx0 + 0, triangle ) );
    }

[Marvin Fröhlich]

Good work. I have committed your fix.

Marvin