next »

[lonesomeStranger]

Wouldn't it work to store a duration for each key frame and use this time instead of the same time for all key frames, if given?

I'm already using time values (not duration) for keyframes anyway.
The point is in that keyframes should be associated with bones rather than with KeyFrameController.
The controller will have 2 keyframes - placeholders as I realize it now.

[lonesomeStranger]

Hi Marvin,

Which geometry type would be better to use for collada: TRIANGLE_ARRAY or another?


Thanks

[Marvin Fröhlich]

Yes

[lonesomeStranger]

Hi Marvin,

I've called Geometry.getNormals( int vi, float[] ) and got exception:

Code:

java.nio.BufferUnderflowException
at java.nio.DirectFloatBufferU.get(DirectFloatBufferU.java:221)
at org.jagatoo.geometry.GeomNioFloatData.get(GeomNioFloatData.java:259)
at org.jagatoo.geometry.GeometryDataContainer.getNormals(GeometryDataContainer.java:771)
at org.xith3d.scenegraph.Geometry.getNormals(Geometry.java:978)
at org.xith3d.loaders.models.animations.SkeletalKeyFrameController.<init>(SkeletalKeyFrameController.java:387)

Do I something wrong or maybe there's a bug (in GeometryDataContainer.getNormals() )?

My code:

Code:

        this.bindPoseCoords = new float[shape.getGeometry().getVertexCount() * 3];
        this.bindPoseNormals = new float[shape.getGeometry().getVertexCount() * 3];
        geom.getCoordinates( 0, bindPoseCoords );
       
        geom.getNormals( 0, bindPoseNormals );

GeometryDataContainer:

Code:

    public void getNormals( int vertexIndex, float[] floatArray )
    {
        if ( !hasNormals() )
            throw new IllegalStateException( "No normals defined" );
       
        for ( int i = 0; i < floatArray.length / 3; i++ )
            normals.get( vertexIndex + ( i * 3 ), 3, normalsOffset / 4L, floatArray, i * 3, 3 );
    }

Regards,

[Marvin Fröhlich]

I don't know the collada code much better than you. I would have to search through the code just as you would .

Marvin

[lonesomeStranger]

I don't know the collada code much better than you. I would have to search through the code just as you would .

This is not the collada code but is the general jagatoo code .
I guess the code below should contain i instead of i * 3 in both places:

Code:

    public void getNormals( int vertexIndex, float[] floatArray )
    {
        ...
        for ( int i = 0; i < floatArray.length / 3; i++ )
            normals.get( vertexIndex + ( i * 3 ), 3, normalsOffset / 4L, floatArray, i * 3, 3 );
    }

I hesitate to modify general code without your blessing  .

[Marvin Fröhlich]

Sure, go ahead .

[lonesomeStranger]

Hi Marvin,

Finally I can report that I'm ready to commit Collada fix.
Sorry that it took so long time.

Collada loader is working on test models - `match stick' and `fantassin'.
Test models are exported from Blender using unofficial fix of plugin script that can be downloaded from here.

The loader is working now in the similar way as other loaders do.

Would you like to preview the changes before commit (at least xith3d part)?

[Marvin Fröhlich]

I trust you. And tbh, any change to the curernt collada loader can only be an improvement. So just go ahead and commit it. I will certainly have a look at the changes though just to stay tuned.

Thanks a lot for the fix and don't worry about being too late or something. Good things need time.

Marvin

[lonesomeStranger]

commited.