next »

[kerno]

Hi,
it seems that MD2Model.readGLCommands loops infinitely when no GL commands are defined in the file (and the GL commands offset is 0, which is the case in newest UFO: AI files).
I could overcome the problem by just not entering the GL commands loop (from line 364) if the header.numGlCommandBytes is 0 (numGlCommandBytes wasn't used anywhere before).
Just mentioning in case someone could fix/commit it in Jagatoo...
Thanks & regards

Code:

# patch for src/org/jagatoo/loaders/models/md2/MD2File.java
@@ -361,6 +361,7 @@
          */
         
         //for ( int i = 0; i < numCommands; i++ )
+        if(header.numGlCommandBytes > 0)
         while ( true )
         {
             int indicator = in.readInt();

[Marvin Fröhlich]

Thanks for the patch. I have committed your fix.

[kerno]

Thanks for quick response.
It seems I was happy a bit too early. While the fix makes the loader accept the MD2 files with no GL commands, it does not help the model to load properly. If I understood the loader code correctly - the triangles' section is ignored and the loader relies on the GL commands to create shapes (correct me, please, if I'm wrong). I didn't notice at first that some models 'disappeared' from my scene.
I just switched back to some older MD2s with the proper GL commands which is no big deal for me but if you could give some guidance - I could try to see if I can fix the loader to load models with no GL cmds. Where should I start looking? (or just RTFM for MD2? )
Thanks & regards