next »

[Mathias 'cylab' Henze]

I have refactored the GLSLShaderProgram code to GLSL ShaderProgram, GLSLShaderProgramProgram and GLSLShaderProgramParameters. This makes it possible to reuse the same GLSLShaderProgram with different parameters for different shapes.

If anyone has a better idea for the naming scheme, please tell me .

Maybe one of the two should be named GLSLShaderProfile or GLSLShaderConfiguration etc.

[Marvin Fröhlich]

Sound like a good idea to me.

GLSLShaderProgramConfiguration
  -> GLSLShaderProgram
       -> GLSLVertexShader[]
       -> GLSLFragmentShader[]
  -> GLSLShaderParameters (or maybe GLSLUniformParameters?)

What do you think?

Marvin

[Mancer]

I think the double "GLSLShaderProgram" label could be confusing for new users.

First, what is the interest of the abstract class GLSLShader ?
Why the "GLSLShaderProgramConfiguration" is not simply this GLSLShader?

[Marvin Fröhlich]

A shader is simply one "component" of a Shader Program. The Shader Program is composed of different shaders (some vertex-shaders and some fragment-shaders). The Shader Program is attributed by uniform variables. therefore we need a container class, that holds the collection of shaders and the assotiated parameters.

The reason for the need for the container class, instead of the way it was before (GLSLShaderProgram, contains shaders and parameters) is, that switching a ShaderProgram in the GL is the most expensive operation possible. Therefore we need a way to use the same (not an equal one, but the same) ShaderProgram for multiple Shape3Ds at a time, but with different uniform variables (i.e. their values).

As you may see, using GLSLShaderProgramConfiguration for a GLSLShader doesn't make much sense.

The abstract GLSLShader is needed to handle GLSLVertex- and GLSLFragmentShaders uniformly.

Marvin

[Mathias 'cylab' Henze]

I would like to keep the class names short. What about

GLSLContext
  -> GLSLProgram
       -> GLSLVertexShader[]
       -> GLSLFragmentShader[]
  -> GLSLParameters

I think we can omit the word Shader in most of the classes, because of GLSL being an abbreviation of GL Shading Language...

[Mancer]

I would like to keep the class names short. What about

GLSLContext
  -> GLSLProgram
       -> GLSLVertexShader[]
       -> GLSLFragmentShader[]
  -> GLSLParameters

I think we can omit the word Shader in most of the classes, because of GLSL being an abbreviation of GL Shading Language...

Sounds good to me.

[Marvin Fröhlich]

I would like to keep the class names short. What about

GLSLContext
  -> GLSLProgram
       -> GLSLVertexShader[]
       -> GLSLFragmentShader[]
  -> GLSLParameters

I think we can omit the word Shader in most of the classes, because of GLSL being an abbreviation of GL Shading Language...

I agree almost totally. Since GLSLShaderProgram is an implementation/extension of the abstract class ShaderProgram it is not only common use, but also nice to use a prefix plus the name of the abstract class. And the "S" from GLSL doesn't obsolete the Shader term, since it means "Shading-Language". So we have a ShaderProgram in the GL-shading-language.

I really like GLSLContext .

So:
GLSLContext
  -> GLSLShaderProgram
       -> GLSLVertexShader[]
       -> GLSLFragmentShader[]
  -> GLSLParameters

ok?

Marvin

[Mathias 'cylab' Henze]

yep

[Mancer]

/signed

 

[Marvin Fröhlich]

I have renamed the classes as above.

Marvin