next »

[lonesomeStranger]

Hi Marvin,

I created two new methods in the Geometry class (setCoordinate0 and setNormal0) to use them in SkeletalKeyFrameController for performance reasons:

Code:

private void updateGeometry( Geometry geom )
    {
        ...
        for ( int i = 0; i < geom.getVertexCount(); i++ )
        {
            ...
            geom.setCoordinate0( i, vSumX, vSumY, vSumZ );
            if ( geom.hasNormals() )
            {
                geom.setNormal0( i, nSumX, nSumY, nSumZ );
            }
        }
        geom.setBoundsDirty();
        geom.getOpenGLReference_DL_GeomData().invalidateNames();
        geom.getOpenGLReference_DL().invalidateNames();

        shape.updateBounds( false );
    }

If you deem it's a bad idea I'll remove these methods.

[Marvin Fröhlich]

I didn't know, what these methods are good for. Keep them and feel free to remove my comment from the code. But I suggest to rename them to something more meaningful than *0.

Theoretically these methods shouldn'T be in the public API. But there are a lot of methods, that currently spam the public API, which would all need to be revised and hidden somehow. But that would cost a lot of time. And in the end nobody will care about a method called setNormalButDontUseThisYouLazyBastard() .

So just go ahead with your impressive and great work.. well if possible, deactivate your auto format trigger to preserve indentations .

Marvin

[lonesomeStranger]

The methods are renamed and also the comments are added briefly explaining them usage.

[Marvin Fröhlich]

Thanks