next »

[synopia]

Rev 1327, FPIHMovementConstraints.java, L128

If any value in viewEuler is Infinity, those while loops will never end.

have a nice day and thanks for xith ;-)

[Marvin Fröhlich]

Rev 1327, FPIHMovementConstraints.java, L128

If any value in viewEuler is Infinity, those while loops will never end.

have a nice day and thanks for xith ;-)

Thanks for the hint. I will fix that soon.

Marvin

[Pandaemonium]

I've seen that code too and wondered about that. Shouldn't that logic simply use a mod with 2*pi to limit euler, instead of the while loop?

[Marvin Fröhlich]

I've seen that code too and wondered about that. Shouldn't that logic simply use a mod with 2*pi to limit euler, instead of the while loop?

A "mod"? Do you mean a modulo?

Modulo is an integer operation. I am simulating the modulo operation with this while loop. In 99.99% of the cases the incoming values will be in range [-2.x*p, +2.x*p] (with a small x), so the loop won't have more than one iteration and therefore this is not a performance issue.

Marvin

[Marvin Fröhlich]

Hmm... short question: Why should the values ever be inifinity??? What are you doing with the FPIH or its constraints? I don't see, how you could ever make it be infinity by a simple mouse movement - may it be as extreme as possible. And the digital rotation (e.g. initiated by a keyboard key press) should also not be able to make it infinity.

Of course there should be a check to avoid the endless loop. But I was just wondering.

Marvin

[Pandaemonium]

A "mod"? Do you mean a modulo?

Yep, that's what I meant.

Modulo is an integer operation.

Yep, that's right. Just ignore me. I wasn't thinking. 

['n ddrylliog]

>> mod is an integer operation
In theory, yep. But for example, on my TI-89, (AMS), it works with floating numbers, e.x. :

Code:

3 % 2 = 1
3.1 % 2 = 1.1
3 % 1.2 = 0.8

Haven't tested it in Java, though...